[#8683] platform-mail: update styling #5919
Merged
+58
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goapunk
reviewed
Jan 9, 2025
There was a problem hiding this comment.
Generally looks good to me, I left a question regarding the bootstrap classes. The story says the button to get to the email form should be in the burger menu, however currently it's in the user indicator, right? I forgot what we discussed yesterday, did we say to not move it for now?
Edit: ah nevermind, just saw your burger menu PR!
meinberlin/apps/platformemails/templates/meinberlin_platformemails/platformemail_form.html
Outdated
Show resolved
Hide resolved
goapunk
reviewed
Jan 9, 2025
meinberlin/apps/platformemails/templates/meinberlin_platformemails/platformemail_form.html
Outdated
Show resolved
Hide resolved
vellip
force-pushed
the
pv-2025-01-platform-mail-design
branch
from
9477afe to
f0e0468
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
adapt page to new styling and make sender field required and adapt default values for form.
Tasks