[#8662] Add plans (Vorhaben) checkbox #5950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sevfurneaux
force-pushed
the
sf-2025-add-plans-checkbox
branch
from
b3abb89 to
3b21b49
Compare
vellip
reviewed
Jan 20, 2025
| @@ -152,6 +155,21 @@ export const ProjectsControlBar = ({ | |||
| typeaheadSelected={filters.organisation} | |||
| multipleBoolean | |||
| /> | |||
| <fieldset className="control-bar__checkboxes"> | |||
| <legend className="control-bar__checkboxes-legend">{translated.onlyShow}:</legend> | |||
There was a problem hiding this comment.
Should me move the punctuation also into the translated string?
There was a problem hiding this comment.
Thanks, I've moved the : into the translated string 👍
| } | ||
|
|
||
| .modul-facetingform .facetingform__container .control-bar__checkboxes-legend { | ||
| float: left; |
There was a problem hiding this comment.
Should we use flexbox instead to avoid any confusion in the future?
There was a problem hiding this comment.
I totally wanted to use flex, but making legends inline only works with float: left 🫠: Today I learned: How to style a fieldset's legend element as display inline.
sevfurneaux
force-pushed
the
sf-2025-add-plans-checkbox
branch
from
3b21b49 to
1deb05e
Compare
hom3mad3
approved these changes
Jan 21, 2025
sevfurneaux
force-pushed
the
sf-2025-add-plans-checkbox
branch
from
1deb05e to
962a0f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR adds the plans (Vorhaben) checkbox.
Tasks