Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#8756] cms: add project tile and blocks for projects and remove storefronts #5957

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

vellip
Copy link
Collaborator

@vellip vellip commented Jan 21, 2025

Describe your changes
Re-uses an old block to allow for a selection of projects to be displayed in wagtail pages. Also updates the project tile django include to resemble the newly created JSX version and removes the old storefront logic.

Tasks

  • PR name contains story or task reference
  • Steps to recreate and test the changes
  • Documentation (docs and inline)
  • Tests (including n+1 and django_assert_num_queries where applicable)
  • Changelog

Currently, django doesn't work due to me deleting the storefronts.py in cms/models/ but some old migration depending on that. Not sure how to handle this best. Any ideas @goapunk ?

@vellip vellip requested review from goapunk and hom3mad3 January 21, 2025 13:31
Copy link
Contributor

@hom3mad3 hom3mad3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the frontend part looks good to me! @goapunk i'll let you have a look at the rest

@vellip vellip force-pushed the pv-2025-01-project-teaser-block branch 2 times, most recently from f5a6f0c to cfbdbf4 Compare January 22, 2025 15:03
Copy link
Contributor

@goapunk goapunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@goapunk
Copy link
Contributor

goapunk commented Jan 22, 2025

@vellip feel free to merge once coveralls fixed their expired certificate and the ci is passing again. You might have to restart it

@vellip vellip force-pushed the pv-2025-01-project-teaser-block branch from cfbdbf4 to 7d7f199 Compare January 23, 2025 08:48
@vellip vellip force-pushed the pv-2025-01-project-teaser-block branch from 7d7f199 to 2fec833 Compare January 23, 2025 08:49
@vellip vellip merged commit ec2899f into dev Jan 23, 2025
2 checks passed
@vellip vellip deleted the pv-2025-01-project-teaser-block branch January 23, 2025 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants