euth/contrib: overwrite module django admin to redirect to project #2495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fuzzylogic2000
requested changes
Mar 18, 2022
euth/contrib/admin.py
Outdated
Comment on lines
9
to
21
| class ProjectFilter(ProjectAdminFilter): | ||
| project_key = 'module__project' | ||
|
|
||
|
|
||
| class ItemAdmin(admin.ModelAdmin): | ||
| list_filter = ( | ||
| 'module__project__organisation', | ||
| 'module__project__is_archived', | ||
| ProjectFilter | ||
| ) | ||
| list_display = ('__str__', 'creator', 'created') | ||
| readonly_fields = ('creator',) | ||
| date_hierarchy = 'created' |
There was a problem hiding this comment.
We don't need to copy the ItemAdmin, as this is not used in the ModuleAdmin. We use it in some projects (see mB) to display and filter the items.
euth/contrib/admin.py
Outdated
Comment on lines
25
to
29
| inlines = [ | ||
| phase_admin.PhaseInline | ||
| ] | ||
| list_filter = ('project__organisation', 'project') | ||
| list_display = ('__str__', 'name') |
There was a problem hiding this comment.
Instead of copying this over, you could inherit from a4s ModuleAdmin and only add the view_on_site method.
from adhocracy4.modules.admin import ModuleAdmin as A4ModuleAdmin
class ModuleAdmin(A4ModuleAdmin):
...
sabinammm
force-pushed
the
sm-2022-03-view-module-on-site-issue
branch
from
ebaecc5 to
71fd246
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2136