Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade wagtail to 5.2 and django to 4.2 #2696

Merged
merged 6 commits into from
Oct 30, 2024

Conversation

m4ra
Copy link
Contributor

@m4ra m4ra commented Oct 24, 2024

in process

@m4ra m4ra force-pushed the mk-2024-10-upgrade-wagtail-django branch from 3c346f4 to 1ea842b Compare October 29, 2024 12:31
@m4ra m4ra changed the title [WIP] upgrade wagtail to 5.2 and django to 4.2 upgrade wagtail to 5.2 and django to 4.2 Oct 29, 2024
@m4ra m4ra requested review from fuzzylogic2000 and goapunk and removed request for fuzzylogic2000 October 29, 2024 12:32
Copy link
Contributor

@goapunk goapunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good, just a small comment on the TitleFieldPanel.

home/models/base_pages.py Outdated Show resolved Hide resolved
@m4ra m4ra force-pushed the mk-2024-10-upgrade-wagtail-django branch from 1ea842b to de4d5f1 Compare October 29, 2024 16:03
@m4ra m4ra requested a review from goapunk October 29, 2024 16:03
Copy link
Contributor

@goapunk goapunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goapunk
Copy link
Contributor

goapunk commented Oct 29, 2024

I think we need to update the CI to ubuntu 24.04 and python 3.11 to make the tests pass

@m4ra
Copy link
Contributor Author

m4ra commented Oct 29, 2024

uhm, django docs, says that backports zoneinfo is installed automatically for python 3.8. but doesn't look like it :/
I will add the CI updates.

zoneinfo is part of the Python standard library from Python 3.9. The backports.zoneinfo package is automatically installed alongside Django if you are using Python 3.8.

@m4ra
Copy link
Contributor Author

m4ra commented Oct 29, 2024

@goapunk the noble update for opin hasn't been merged yet in the admin repo.
Also any specific reason you suggest python 3.11 instead of python 3.12?

@m4ra m4ra requested a review from goapunk October 29, 2024 16:56
@m4ra
Copy link
Contributor Author

m4ra commented Oct 30, 2024

@goapunk should we wait to merge this until ubuntu noble is set in the admin repo for opin?

@goapunk
Copy link
Contributor

goapunk commented Oct 30, 2024

@goapunk the noble update for opin hasn't been merged yet in the admin repo. Also any specific reason you suggest python 3.11 instead of python 3.12?

oh, probably was by mistake, if noble uses 3.12 then 3.12 of course

@goapunk
Copy link
Contributor

goapunk commented Oct 30, 2024

@goapunk should we wait to merge this until ubuntu noble is set in the admin repo for opin?

I think @P4rcev4l merged it today, so we can go ahead

@goapunk goapunk merged commit c607f7d into main Oct 30, 2024
2 of 3 checks passed
@goapunk goapunk deleted the mk-2024-10-upgrade-wagtail-django branch October 30, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants