Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Network: firewall controller chain #2150

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Network: firewall controller chain #2150

merged 1 commit into from
Nov 22, 2023

Conversation

cheina97
Copy link
Member

@cheina97 cheina97 commented Nov 16, 2023 •
edited
Loading

Description

This PR adds the creation, deletion, and update of firewall rules in FirewallConfiguration controller

@adamjensenbot
Copy link
Collaborator

Hi @cheina97. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@cheina97
Copy link
Member Author

/build

@cheina97 cheina97 force-pushed the frc/nftcontrollerchains branch 3 times, most recently from a599696 to faa8776 Compare November 17, 2023 11:47
@cheina97 cheina97 force-pushed the frc/nftcontrollerchains branch 3 times, most recently from ccce51e to 19549a7 Compare November 20, 2023 12:56
@cheina97
Copy link
Member Author

/build

@cheina97 cheina97 force-pushed the frc/nftcontrollerchains branch from 19549a7 to 8c9ec8b Compare November 20, 2023 13:10
@cheina97 cheina97 marked this pull request as ready for review November 20, 2023 13:29
@cheina97
Copy link
Member Author

/build

@cheina97 cheina97 force-pushed the frc/nftcontrollerchains branch from 8c9ec8b to 75d9032 Compare November 21, 2023 09:28
@cheina97 cheina97 force-pushed the frc/nftcontrollerchains branch from 75d9032 to 4c6529c Compare November 21, 2023 16:36
@cheina97
Copy link
Member Author

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Nov 22, 2023
@adamjensenbot adamjensenbot merged commit b0ec148 into liqotech:network-external Nov 22, 2023
8 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Nov 22, 2023
@cheina97 cheina97 deleted the frc/nftcontrollerchains branch November 22, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleoli aleoli aleoli approved these changes

@francescodanzi francescodanzi francescodanzi approved these changes

@fra98 fra98 Awaiting requested review from fra98

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cheina97 @adamjensenbot @aleoli @francescodanzi