Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IPAM] support reserved networks #2829

Merged
merged 1 commit into from
Nov 28, 2024
Merged

[IPAM] support reserved networks #2829

merged 1 commit into from
Nov 28, 2024

Conversation

fra98
Copy link
Member

@fra98 fra98 commented Nov 22, 2024

Description

This PR adds the support for reserved network in the new IPAM

@adamjensenbot
Copy link
Collaborator

Hi @fra98. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@pull-request-size pull-request-size bot added size/L and removed size/M labels Nov 25, 2024
@fra98 fra98 force-pushed the frt/ipam-reserved-nets branch from 43b6f39 to 380ad7a Compare November 25, 2024 15:16
@pull-request-size pull-request-size bot added size/M and removed size/L labels Nov 25, 2024
@fra98 fra98 force-pushed the frt/ipam-reserved-nets branch from 380ad7a to 82cff7d Compare November 26, 2024 11:16
@pull-request-size pull-request-size bot added size/L and removed size/M labels Nov 26, 2024
@fra98 fra98 force-pushed the frt/ipam-reserved-nets branch 2 times, most recently from 7fde8ae to a0c3a30 Compare November 26, 2024 13:56
@pull-request-size pull-request-size bot added size/M and removed size/L labels Nov 26, 2024
@fra98
Copy link
Member Author

fra98 commented Nov 26, 2024

/build

@fra98 fra98 force-pushed the frt/ipam-reserved-nets branch from a0c3a30 to 125d264 Compare November 26, 2024 14:57
@fra98 fra98 marked this pull request as ready for review November 26, 2024 14:59
@fra98 fra98 requested review from aleoli and cheina97 November 26, 2024 15:31
@fra98 fra98 force-pushed the frt/ipam-reserved-nets branch from 125d264 to 7c89c2c Compare November 27, 2024 09:42
@fra98 fra98 mentioned this pull request Nov 27, 2024
Merged
@fra98
Copy link
Member Author

fra98 commented Nov 28, 2024

/build

@fra98 fra98 force-pushed the frt/ipam-reserved-nets branch from 7c89c2c to b0b7977 Compare November 28, 2024 09:57
@pull-request-size pull-request-size bot added size/L and removed size/M labels Nov 28, 2024
@fra98
Copy link
Member Author

fra98 commented Nov 28, 2024

/build

@fra98 fra98 force-pushed the frt/ipam-reserved-nets branch from b0b7977 to 35be9f4 Compare November 28, 2024 10:11
@fra98
Copy link
Member Author

fra98 commented Nov 28, 2024

/build

1 similar comment
@fra98
Copy link
Member Author

fra98 commented Nov 28, 2024

/build

@fra98 fra98 merged commit 3473545 into liqotech:ipam Nov 28, 2024
10 checks passed
@fra98 fra98 deleted the frt/ipam-reserved-nets branch November 28, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleoli aleoli aleoli approved these changes

@cheina97 cheina97 Awaiting requested review from cheina97

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fra98 @adamjensenbot @aleoli