Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[liqoctl] improve liqoctl version error message #2897

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

claudiolor
Copy link
Contributor

Description

This patch improves the returned error message when it is not possible to retrieve the version of the Liqo server, by changing the error type from ERROR to WARNING, as an error is expected when there is no remote cluster with Liqo installed. Moreover, it clarifies that the error is related to the version of the Liqo instance running in the cluster and provides a set reasons why an error is produced.

Before
image

After
image

@adamjensenbot
Copy link
Collaborator

Hi @claudiolor. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • feat: 🚀 New Feature
  • fix: 🐛 Bug Fix
  • refactor: 🧹 Code Refactoring
  • docs: 📝 Documentation
  • style: 💄 Code Style
  • perf: 🐎 Performance Improvement
  • test: ✅ Tests
  • chore: 🚚 Dependencies Management
  • build: 📦 Builds Management
  • ci: 👷 CI/CD
  • revert: ⏪ Reverts Previous Changes

@github-actions github-actions bot added the fix Fixes a bug in the codebase. label Jan 8, 2025
@fra98
Copy link
Member

fra98 commented Jan 9, 2025

/rebase test=true

This patch improves the returned error message when it is not possible
to retrieve the version of the Liqo server, by changing the error type
from ERROR to WARNING, as an error is expected when there is no remote
cluster with Liqo installed. Moreover, it clarifies that the error is
related to the version of the Liqo instance running in the cluster and
provides a set reasons why an error is produced.
@adamjensenbot adamjensenbot force-pushed the clo/fix-liqoctl-version branch from 4941134 to 0638b6a Compare January 9, 2025 15:12
@fra98
Copy link
Member

fra98 commented Jan 9, 2025

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Jan 9, 2025
@adamjensenbot adamjensenbot merged commit 6171bec into liqotech:master Jan 9, 2025
14 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fixes a bug in the codebase. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants