Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lite-modal plugin #455

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

Mandarancio
Copy link
Contributor

Add lite-modal plugin: a fully customizable modal editing for Lite XL

Copy link
Member

@Guldoman Guldoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general you can test your changes with:

lpm run --ephemeral https://github.com/Mandarancio/lite-xl-plugins:patch-2 modal

manifest.json Outdated Show resolved Hide resolved
fixed issues
@Mandarancio
Copy link
Contributor Author

In general you can test your changes with:

lpm run --ephemeral https://github.com/Mandarancio/lite-xl-plugins:patch-2 modal

Thank you very much for the information I wanted to test it but I was unable to find this info, would be possible to add some sort of guidelines on how to submit plugins?

@Mandarancio
Copy link
Contributor Author

well... lpm on my arch does not have the flag --ephemeral and if I try with --repository it fail with attempt to index a nil value

@Mandarancio Mandarancio marked this pull request as draft July 12, 2024 07:56
@Mandarancio
Copy link
Contributor Author

@Guldoman I will update the plugin configuration using the tips you gave me on the keyhud (using config.plugins and common.merge)

@Guldoman
Copy link
Member

would be possible to add some sort of guidelines on how to submit plugins?

Yeah would be a good idea to add it to the README.

well... lpm on my arch does not have the flag --ephemeral and if I try with --repository it fail with attempt to index a nil value

How did you install lpm? Is there any error when you use --ephemeral?

@Mandarancio
Copy link
Contributor Author

would be possible to add some sort of guidelines on how to submit plugins?

Yeah would be a good idea to add it to the README.

well... lpm on my arch does not have the flag --ephemeral and if I try with --repository it fail with attempt to index a nil value

How did you install lpm? Is there any error when you use --ephemeral?

I checked my install and I saw that I was using a old (1.0.x) version of lpm, I updated it and now it works!

@Mandarancio Mandarancio marked this pull request as ready for review November 18, 2024 09:26
@adamharrison
Copy link
Member

I really like the look of this! I'm going to test this now.

@adamharrison
Copy link
Member

If I test this, should I use the most recent commit on your repository?

@adamharrison
Copy link
Member

adamharrison commented Jan 5, 2025

OK, couple things as I go through this.

  1. You should probably set keymaps to a table; your examples in your README fail with attempt to index a nil value (field 'keymaps') if you try and paste them into your user config; you need to first initialize keymaps to a table.
  2. If you don't specify a keymap for a modal, you get an error in general trying to press any key; should probably default to an empty keymap.
  3. I'd suggest throwing in a full example config that can be just copy and pasted into your user config to allow for easy testing.
  4. on_key_passtrought should be on_key_passthrough

But other than that, I love this. I tested the master branch of the repository. Let me know if that's the commit you'd prefer to pin, and I'll pin that one, and merge this. (And I'll probably write a modal-vim plugin which uses this with a prefab config that replicate vim).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants