Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve langauge_kdl #479

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Improve langauge_kdl #479

wants to merge 11 commits into from

Conversation

Tamnac
Copy link
Contributor

@Tamnac Tamnac commented Sep 10, 2024

  • fix formatting (should be all 2-space indents now)
  • couple of improvements suggested by @Guldoman
  • add support for node and nested multiline comments (also thanks to guldoman)

Guldoman
Guldoman reviewed Sep 20, 2024
View reviewed changes
Copy link
Member

@Guldoman Guldoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a version bump.

Guldoman
Guldoman reviewed Sep 20, 2024
View reviewed changes
plugins/language_kdl.lua
Comment on lines +48 to +51
{
pattern = { "/%-.*{", "}" },
type = "comment", syntax = node_comment
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My suggestion in #477 also covered comments like this:

mynode /-"commented" "not commented" {
  a
  b
}

This doesn't, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, your suggestion was very helpful but it only 80% worked, so I made some tweaks. This is how it behaves now, which I believe matches the spec

image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, only the single parameter should be commented.
In what cases did my suggestion not work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Guldoman Guldoman Guldoman left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tamnac @Guldoman