feat: allow route_reverse params of type uuid to be passed as str #3972
+46
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size: small
type/feat
pr/external
Triage Required 🏥
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3972 +/- ##
=======================================
Coverage 98.34% 98.34%
=======================================
Files 347 347
Lines 15755 15756 +1
Branches 1741 1741
=======================================
+ Hits 15495 15496 +1
Misses 124 124
Partials 136 136 ☔ View full report in Codecov by Sentry. |
|
Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/3972 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This allows params of type UUID to be passed as strings (e.g. their hex representation) into route_reverse (just like datetime, Path etc.). I don't know if the test is really necessary, but that is for the maintainers to decide.
Originally I intended to allow int too, but this broke about 20 tests I did not feel confident to fix them all in a reasonable amount of time.
Discussed in #3968