Make Allow middleware thread-safe without duping #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial
Allow
middleware implementation was not thread-safe. A "temporary" (eight years ago!) hack was put in place that simply duped the middleware stack to ensure threadsafety. Not only is this a hack, but it also adds unnecessary overhead to each request since each dup generated more objects that would need to be GC'd.This change makes the
Allow
middleware thread-safe without duping, and yields a whopping 85x (!) increase in performance (via bin/benchmark):Before:
After:
This implementation uses a simplified Config class that is no longer backed by a hash. This required dropping support for passing config options to the middleware, but that likely was mostly used in tests.