Continue project cleanup #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use declaration data to simplify one-line DocBlock handling in `NormaliseComments` - Check for braces before calling `isMatchOpenBrace()` to improve efficiency of `IndexSpacing` - Fix `StandardSpacing` issue where only the last constructor in the document with a promoted parameter is formatted correctly - Fix issue where newlines are not suppressed inside parentheses in DNF types
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #183 +/- ##
============================================
+ Coverage 95.84% 96.06% +0.22%
+ Complexity 2799 2791 -8
============================================
Files 67 67
Lines 7140 7109 -31
============================================
- Hits 6843 6829 -14
+ Misses 297 280 -17 ☔ View full report in Codecov by Sentry. |
- Remove `isDoubleArrowAfterFn()` - Allow `adjacent()` to return tokens at the end of statements unless they are statement delimiters - Simplify `prevReal()` and `nextReal()` and replicate in `doRemoveWhitespace()`, `PreserveNewlines` and `EssentialSpacing` to improve performance - Refactor `hasNewlineAfterPrevCode()` and `hasNewlineBeforeNextCode()` for consistency - Fix improper use of `hasNewlineAfterPrevCode()` in `StandardIndentation`
- Remove `$AlignChainAfterNewline` - Derive `$NewlineBeforeFnDoubleArrow` from `$Psr12` and don't allow it to be set separately - Preserve comment type when truncating for comparison - Add `TokenCollection::from()`
No code changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.