Fix bracket placement issues #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Upstream changes mean `pretty-php` now refuses to run as root
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #186 +/- ##
============================================
- Coverage 96.03% 95.92% -0.12%
- Complexity 2792 2805 +13
============================================
Files 67 68 +1
Lines 7119 7160 +41
============================================
+ Hits 6837 6868 +31
- Misses 282 292 +10 ☔ View full report in Codecov by Sentry. |
- Move bracket mirroring from `StandardIndentation` to standalone rule
`PlaceBrackets` and prioritise it to run earlier
- Refactor and/or prioritise other rules so changes to vertical
whitespace near brackets are applied before `PlaceBrackets`, incl.:
- Move suppression of whitespace in empty `for` expressions from
`VerticalSpacing` to `StandardSpacing`
- Place `for` expressions on their own lines in `StrictExpressions`
and `SemiStrictExpressions`
- Run `StrictLists` after `*StrictExpressions` to ensure `for`
expressions that break over multiple lines are not collapsed
- Add `FOR_PARTS` to token data and parse `for` expressions in `Parser`
instead of duplicating code in `VerticalSpacing`
- Add `TokenCollection::setWhitespace()` and adopt in scenarios where
suppression of whitespace should not be removed
- Similarly, replace `TokenCollection::applyInnerWhitespace()` with
`setInnerWhitespace()`
- `setWhitespace()` -> `setTokenWhitespace()` - `applyWhitespace()` -> `applyTokenWhitespace()`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.