Continue project cleanup #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add blank lines after loosely-spaced declarations so comments cannot appear on the next line - Allow for comments between DocBlocks and subsequent declarations when checking input spacing and suppressing blank lines - Don't always add a blank line between declarations separated by comments other than DocBlocks
- Remove `Formatter::getTokens()` in favour of access via `Formatter::$Document` - Narrow type returned via `FormatterException::getData()`
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #194 +/- ##
=========================================
Coverage 95.93% 95.93%
- Complexity 2812 2826 +14
=========================================
Files 68 69 +1
Lines 7177 7203 +26
=========================================
+ Hits 6885 6910 +25
- Misses 292 293 +1 ☔ View full report in Codecov by Sentry. |
- Move code into an `Updater` class - Add tests from `nikic/php-parser` - Remove non-advisory code validation in case the PHP version running the script is not compatible with versions targeted by listings
- Update `update-out-fixtures.php` for consistency - Clean up `.gitattributes` in fixture directory
Necessary to prevent exceptions like `Deprecated: The (real) cast is deprecated, use (float) instead`
e.g. import statements like `use A\B\{C\D, function b\c, const D};`
Binary prefixes will be removed from all strings in a future update. They are already removed from constant strings if `simplify-strings` is enabled.
- Add `NormaliseBinaryStrings` to assign the same token ID to the opening delimiter of strings like `b"$foo"` as on PHP >= 8.0
This fixes issues with inconsistent output when code contains multiple line endings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.