Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue where nowdocs with whitespace before labels are not detected #198

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

lkrms
Copy link
Owner

@lkrms lkrms commented Jan 20, 2025

No description provided.

Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.02%. Comparing base (eb5a710) to head (87cb12d).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #198   +/-   ##
=========================================
  Coverage     96.01%   96.02%           
- Complexity     2826     2830    +4     
=========================================
  Files            69       69           
  Lines          7203     7214   +11     
=========================================
+ Hits           6916     6927   +11     
  Misses          287      287           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lkrms lkrms force-pushed the fix-nowdoc-detection branch from 46f7109 to 8f67db3 Compare January 21, 2025 00:19
- Fix issue where nowdocs with whitespace before labels are not detected
  (reported in #195)
- Fix issue where newlines before heredocs at the start of statements
  are suppressed when strict PSR-12 compliance is enabled
@lkrms lkrms force-pushed the fix-nowdoc-detection branch from 8f67db3 to 87cb12d Compare January 21, 2025 01:04
@lkrms lkrms merged commit 314f291 into main Jan 21, 2025
27 checks passed
@lkrms lkrms deleted the fix-nowdoc-detection branch January 21, 2025 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pretty-php fails when there is whitespace between a nowdoc operator and its identifier
1 participant