adding export button #376
adding export button #376
Conversation
|
@llaske please review this PR , I know there are some changes required to include necessary fields in the CSV file I am open to new suggestions and Ideas , your suggestions will be admired Please tell me if there is anything you would like to update , I have tested this on my system |
| const validateAssignment=(assignment)=>{ | ||
| const assign={ |
There was a problem hiding this comment.
Sugarizer Server code follows ES5 syntax, so it better to avoid ES6 syntax.
| common = require('../../helper/common'); | ||
|
|
||
| module.exports = function exportCSV(req, res) { | ||
| var assignment = []; |
There was a problem hiding this comment.
The variable name conflicts with the other variables in the same function, for example assignment on line 9.
There was a problem hiding this comment.
no that will work because of scope in javascript
There was a problem hiding this comment.
Yeah, it will work, but it's better to have a different name for clarity, for example assignments in this case.
| stroke:"", | ||
| fill:"", |
There was a problem hiding this comment.
The fill and stroke information is not relevant to delivery.
| .get(common.getAPIUrl(req) + 'api/v1/assignments') | ||
| .set(common.getHeaders(req)) | ||
| .end(function (error, response) { | ||
| // console.log(response.body); |
There was a problem hiding this comment.
Remove unnecessary comments
There was a problem hiding this comment.
yeah I will create a request to assugnment delivers as you describe me
| async.series([ | ||
| function(callback) { | ||
| superagent | ||
| .get(common.getAPIUrl(req) + 'api/v1/assignments') |
There was a problem hiding this comment.
I don't think the issue is about exporting Assignments. The requirement is for exporting the Deliveries.
| <% } %> | ||
| <% } %> |
There was a problem hiding this comment.
Remove unnecessary whitespace.
|
|
||
| //function for exporting assigment | ||
|
|
There was a problem hiding this comment.
Remove unnecessary comments.
|
thanks @NikhilM98 for resolving my queries |
|
@NikhilM98 I am creating an assignment with a teacher account
|
|
You can log into Sugarizer app with a teacher account and create a journal entry to make it visible here. |
but that page is not opeining because the students don't have any journals, how a student can opt a journal |
|
Open localhost:8080 to access the Sugarizer Client. |
|
but here a student will opt an journal |
|
Create a teacher account from Sugarizer Server dashboard, and log into the Sugarizer Client with the teacher account. |
|
yeah done , but I am not able to give journal to student or creating them, So that they will show me while adding assignemnt |
|
|
|
Looks like your Teacher's journal is empty. Try using Sugarizer Activities, it will create Journal entries. You can assign those activities as an Assignment. |
|
how , can you please give some steps to do that |
|
As there is no Docs so it is difficult to do |
|
journals are showing |
|
but still while creating asssignment that activity option is still not showing |
|
I want to test some things so I need to create some assignments @NikhilM98 please help |
|
Now try to log into Sugarizer Server dashboard with the teacher's account and try to create an assignment. |
|
Yeah doing that but still activities are not showing while creating assignment |
|
I just tested it with a fresh Sugarizer Server instance. It's working: You must be doing something wrong. |
Btw these journal entries do not belong to the user you have logged in with. |
We expect potential contributors to learn to use the application by experimenting with the application. While we understand that this approach may be challenging, it is also the best way to gain a thorough understanding of the application's functionality and how it is used in practice. We do not want to provide a step-by-step documentation for the developers as we believe that the most valuable contributions come from those who have taken the time to really explore and understand the application on their own. We encourage you to spend some time using the application, exploring its various features, and familiarizing yourself with its functionality. This will not only help you gain a better understanding of the application, but it will also help you identify areas where you can make valuable contributions. |
Right @NikhilM98 I agree with your statement that |
|
Docs for the initial deployment of Sugarizer Server are available here. PRs are welcome if you believe that the docs can be improved or the scope of the docs can be extend. |
This reverts commit 8d4d0ce.
|
@NikhilM98 I created my first assignment |
|
@parteekcoder can this PR be closed? |
|
yes , continued at #385 |
issue #366
hey @llaske I am making functionality of exporting assignment , yet I am making this when it is completed I will inform you