Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CIR][CIRGen] Add uwtable attribute #1226

Merged
merged 1 commit into from
Dec 12, 2024
Merged

[CIR][CIRGen] Add uwtable attribute #1226

merged 1 commit into from
Dec 12, 2024

Conversation

smeenai
Copy link
Collaborator

@smeenai smeenai commented Dec 11, 2024

The module-level uwtable attribute controls the unwind tables for any
synthesized functions, and the function-level attribute controls them
for those functions. I'll add support for this attribute to the LLVM
dialect as well, but translate it from CIR directly for now to avoid
waiting on the MLIR addition and a subsequent rebase.

Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the windows failures are probably because I've tainted TOT, right?

@smeenai
Copy link
Collaborator Author

smeenai commented Dec 12, 2024

LGTM, the windows failures are probably because I've tainted TOT, right?

Yup, I believe so, but I'll rebase to confirm.

The module-level uwtable attribute controls the unwind tables for any
synthesized functions, and the function-level attribute controls them
for those functions. I'll add support for this attribute to the LLVM
dialect as well, but translate it from CIR directly for now to avoid
waiting on the MLIR addition and a subsequent rebase.
@smeenai smeenai merged commit 8b74dc0 into llvm:main Dec 12, 2024
6 checks passed
@smeenai smeenai deleted the uwtable branch December 12, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants