Skip to content

Commit

Permalink
perf: Use GitHub's native arm64 runners (#106)
Browse files Browse the repository at this point in the history
GitHub now offers free arm64 runners. This means we can drop QEMU and builds will be much faster.
  • Loading branch information
AaronDewes authored Jan 17, 2025
1 parent 3345da2 commit 9098cc7
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 15 deletions.
11 changes: 3 additions & 8 deletions .github/workflows/on-tag.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ on:
jobs:
build:
name: Build bitcoind
runs-on: ubuntu-22.04
runs-on: ${{ matrix.arch == 'amd64' && 'ubuntu-24.04' || 'ubuntu-24.04-arm' }}

strategy:
matrix:
Expand All @@ -29,11 +29,10 @@ jobs:
- arm64v8

env:
QEMU_VERSION: v5.0.0
DOCKER_BUILDKIT: 1

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4

- name: Setup environment
run: |
Expand Down Expand Up @@ -63,10 +62,6 @@ jobs:
printf " DIR: %s\n" "$DIR"
printf " BUILD: %s\n" "$BUILD"
- name: Register self-compiled qemu
if: matrix.arch != 'amd64'
run: docker run --rm --privileged "meedamian/simple-qemu:$QEMU_VERSION-${{ matrix.arch }}" -p yes

- name: Build ${{ env.APP }}
run: >
docker build --no-cache "$DIR/"
Expand Down Expand Up @@ -130,7 +125,7 @@ jobs:
deploy:
name: Deploy to Docker Hub & Github Releases. Only after successful build.

runs-on: ubuntu-22.04
runs-on: ubuntu-24.04
needs: build

env:
Expand Down
9 changes: 2 additions & 7 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ on:
jobs:
build:
name: Build bitcoind
runs-on: ubuntu-22.04
runs-on: ${{ matrix.arch == 'amd64' && 'ubuntu-24.04' || 'ubuntu-24.04-arm' }}

strategy:
fail-fast: false
Expand All @@ -29,15 +29,10 @@ jobs:
- arm64v8

env:
QEMU_VERSION: v5.0.0
DOCKER_BUILDKIT: 1

steps:
- uses: actions/checkout@v2

- name: Register self-compiled qemu
if: matrix.arch != 'amd64'
run: docker run --rm --privileged "meedamian/simple-qemu:$QEMU_VERSION-${{ matrix.arch }}" -p yes
- uses: actions/checkout@v4

- name: Build ${{ env.APP }}
run: >
Expand Down

0 comments on commit 9098cc7

Please sign in to comment.