Bitcoin full node support #59
Conversation
|
Could we have the option of an actual full node as well as a pruned full node? |
@nolim1t Yes of course, the only change necessary is There could be another compose folder without neutrino, where PRs welcome! |
|
|
Expected output: sudo noma start
✅ media directory exists
✅ noma directory exists
✅ compose directory exists
✅ bitcoind directory exists
✅ bitcoind config file exists
✅ Set rpcauth successfully
✅ lnd directory exists
✅ lnd.conf exists
Creating fullnode_bitcoind_1 ... done
Creating fullnode_lnd_1 ... done
Creating fullnode_invoicer_1 ... done |
| @@ -25,9 +25,9 @@ jobs: | |||
| run: | | |||
| pip install flake8 | |||
| # stop the build if there are Python syntax errors or undefined names | |||
| flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics | |||
| flake8 *.py noma/*.py tests/*.py --count --select=E9,F63,F7,F82 --show-source --statistics | |||
There was a problem hiding this comment.
What are the --select=???? things? Could you tl;dr in a comment above?
|
|
||
| [Routing] | ||
| ; Save bandwidth by only downloading minimum channel filters necessary | ||
| routing.assumechanvalid=1 |
There was a problem hiding this comment.
Isn't that the thing that caused the most recent lnd CVE?
I don't know. Just asking now.
lnd/fullnode/lnd.conf
Outdated
| ; Not using bitcoind as backend by default due to pruning limitations | ||
| [Bitcoin] | ||
| bitcoin.active=1 | ||
| bitcoin.testnet=0 |
There was a problem hiding this comment.
No point in having testnet line here.
| @@ -3,8 +3,8 @@ | |||
| setup( | |||
| name="noma", | |||
| version="0.5.1", | |||
| packages=["noma"], | |||
| install_requires=["psutil", "docopt", "requests", "docker-compose"], | |||
| packages=["noma", "configobj"], | |||
There was a problem hiding this comment.
What's that? Why does it add 2k LOC to the repo here?
There was a problem hiding this comment.
I had to make some changes to the way the library writes out ini files to conform to bitcoind and lnd style.
I'll submit a PR upstream, once it's merged and released configobj/ can be removed
There was a problem hiding this comment.
Cool, just add a comment saying that somewhere :).
Ideally with a link to an issue tracking it.
|
|
||
| bitcoind_conf = "/media/archive/archive/bitcoin/bitcoin.conf" | ||
| bitcoind_conf_exists = pathlib.Path(bitcoind_conf).is_file() | ||
| raise IOError("❌ bitcoin directory missing") |
There was a problem hiding this comment.
if not cfg.BITCOIN_PATH.is_dir():
raise IOError("❌ bitcoin directory missing")
print("✅ bitcoind directory exists")
noma/bitcoind.py
Outdated
| if section: | ||
| return config[section][key] | ||
| try: | ||
| value = config[key] |
There was a problem hiding this comment.
Is try/except is the only way to check if a key exists?
Plus, no check if key[section] exists above.
noma/bitcoind.py
Outdated
| except KeyError: | ||
| print("rpcauth unset") | ||
|
|
||
| if rpcauth_val == '': # only change if value is unset |
There was a problem hiding this comment.
I think it's better when "the happy path" is left most ;).
So flipping this if might improve clarity.
if some-error:
print
return
back to happy path ^o^This fixes a versioning issue on Ubuntu Server for 64-bit ARM
fix KeyError
This adds a pruned
bitcoindwith low resource limits.Intended to provide
invoicerwith mempool capabilities and block verification.Please note that pruned mode will sync from genesis unless a recent chain snapshot is applied.
TODO: