Handle Linux systems that use /lib64 instead of /lib #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Tabby do you mind fixing the cmake so it passes linting? |
|
Not at all! Also yes of course there's a CMake linter, my bad. Must get that set up locally 😅 |
Use CMAKE_INSTALL_LIBDIR variable to set the correct lib folder to use for installing libraries so that CMake looks in the right place for the dependencies when linking
Tabby
force-pushed
the
fix-cmake-lib64-handling
branch
from
7ef751b to
78a46b5
Compare
|
Ugh, I think this approach is wrong, as it causes the Ubuntu build to fail with the error I was getting on Gentoo before this change :/ |
|
going to close now for staleness |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
CMAKE_INSTALL_LIBDIRvariable to set the correct lib folder to use for installing libraries so that CMake looks in the right place for the dependencies when linkingThis shouldn't affect builds on other systems, both Linux and otherwise, but it fixes it for systems that prefer /lib64