Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Update model-downloader.cpp to use obs_module_config_path f… #134

Merged
merged 4 commits into from
Jul 11, 2024

Conversation

royshil
Copy link
Collaborator

@royshil royshil commented Jul 10, 2024

…or retrieving the config folder path

  • Replace the usage of obs_module_get_config_path with obs_module_config_path to retrieve the config folder path in model-downloader.cpp
  • Add a check for a null config_folder and log an info message if it is null
  • Convert the config_folder string to a wstring on Windows using MultiByteToWideChar
  • Update the log messages to provide more descriptive information about the config models folder and the model folder existence in the config folder
  • Use the updated config_folder_str in the std::filesystem::absolute function call

…or retrieving the config folder path

- Replace the usage of obs_module_get_config_path with obs_module_config_path to retrieve the config folder path in model-downloader.cpp
- Add a check for a null config_folder and log an info message if it is null
- Convert the config_folder string to a wstring on Windows using MultiByteToWideChar
- Update the log messages to provide more descriptive information about the config models folder and the model folder existence in the config folder
- Use the updated config_folder_str in the std::filesystem::absolute function call
royshil added 3 commits July 10, 2024 17:13
- Add a condition to check for null timestamps before saving the sentence to srt in the send_sentence_to_file function
- Remove unnecessary code in the set_text_callback function that checks for empty text after suppression
- Update the whisper_loop function to clear the current subtitle if the minimum subtitle duration has passed
@royshil royshil merged commit 58f9131 into master Jul 11, 2024
10 checks passed
@royshil royshil deleted the roy.model_finding_fix branch July 11, 2024 16:22
@TheTawnyFool
Copy link

Hi, I just pulled the cloned the master and built it. If I understand right that should include the update? I still does not give the correct timestamps on my system. I am assuming every time I press record, it creates a new .srt file along with the OBS created clip and should start the timestamps at 00:00:00. It then renames the file when ending the recording to the clip name. Everything is working except it is not timestamping from 00:00:00 correctly on my up-to-date OBS, windows 11 PC.

It is 12:30 pm my time when I started this clip.... it created an srt file with the following info.

1
01:07:52,824 --> 01:07:58,567
blah blah

That appears to be over an hour into the video for some reason.
Thanks again for all your hard work, happy to provide any info I can!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants