enable transcript rename for non-srt files #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schrauger
approved these changes
Oct 10, 2024
…anscription-filter-callbacks.cpp
|
@schrauger can you take a look please? i've simplifed it a bunch |
|
@royshil That all looks good to me. Definitely easier to read, and using the filesystem path library makes sense rather than doing string searches. I haven't tested it, but the logic looks the same after reading over the changes. Thanks for cleaning it up. I appreciate the plugin! |
schrauger
approved these changes
Oct 10, 2024
…anscription-filter-callbacks.cpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.