fix: codegen generating migrations that apply backwards #952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: requires inject comment in `migration/src/lib.rs` to now be `inject-above`
|
I didn't know if I should change CHANGELOG.md#39 since 0.12 is already out. |
Merged
|
Looks good. I put back the "below" comment, so that older version of |
jondot
added a commit
that referenced
this pull request
Nov 9, 2024
* fix: codegen generating migrations that apply backwards BREAKING CHANGE: requires inject comment in `migration/src/lib.rs` to now be `inject-above` * Update lib.rs to be nonbreaking --------- Co-authored-by: Elad Kaplan <[email protected]> Co-authored-by: Dotan J. Nahum <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #949
BREAKING CHANGE: requires inject comment in
migration/src/lib.rsto now beinject-above(and be moved to be after last item)