Simplify download URLs generated by Download button (exclude empty fields) #3625
+22
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #3624 Update `generateDownloadUrl` method to exclude empty parameters from the generated download URLs. * Modify `website/src/components/SearchPage/DownloadDialog/DownloadUrlGenerator.ts` to check for empty values before appending them to the URL. * Add a test case in `website/src/components/SearchPage/DownloadDialog/DownloadDialog.spec.tsx` to verify that empty parameters are excluded from the generated download URLs. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/loculus-project/loculus/issues/3624?shareId=XXXX-XXXX-XXXX-XXXX).
theosanderson
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3624
https://theosanderson-fix-downloa.loculus.org/
Update
generateDownloadUrlmethod to exclude empty parameters from the generated download URLs.website/src/components/SearchPage/DownloadDialog/DownloadUrlGenerator.tsto check for empty values before appending them to the URL.website/src/components/SearchPage/DownloadDialog/DownloadDialog.spec.tsxto verify that empty parameters are excluded from the generated download URLs.For more details, open the Copilot Workspace session.