Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More robust chain time #242

Merged
merged 1 commit into from
Mar 28, 2024
Merged

More robust chain time #242

merged 1 commit into from
Mar 28, 2024

Conversation

gdethier
Copy link
Contributor

  • Chain time now only relies on the slot duration returned by the runtime (no more client-side computation).
  • Removes a couple of deprecated calls in Queries.
  • Left a comment about how to make Vault more robust (but requires runtime-side changes).

@gdethier gdethier requested a review from benoitdevos March 28, 2024 09:49
benoitdevos
benoitdevos approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@benoitdevos benoitdevos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gdethier gdethier merged commit dda1c41 into main Mar 28, 2024
2 checks passed
@gdethier gdethier deleted the feature/improve-chain-time branch March 28, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benoitdevos benoitdevos benoitdevos approved these changes

Assignees

@gdethier gdethier

@benoitdevos benoitdevos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gdethier @benoitdevos