Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parachain node-api #244

Merged
merged 5 commits into from
Apr 5, 2024
Merged

Parachain node-api #244

merged 5 commits into from
Apr 5, 2024

Conversation

benoitdevos
Copy link
Contributor

Companion of logion-network/logion-collator#7

  • node-api is generated for parachain.
  • SDK checks it does connect to Parachain.
  • SS58 prefix is obtained from api.queries.ss58Prefix.
  • Integration tests are now prefix-independent.

Tests

  • node-api tests: ✅
  • client tests: ✅
  • node-api integration tests: ✅ (⚠️ currently require explicit startup/shutdown of the collator node on port 9944, for instance using zombienet as described here).
  • client integration tests: ❌

@benoitdevos benoitdevos requested a review from gdethier April 4, 2024 14:18
gdethier
gdethier approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@gdethier gdethier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

packages/node-api/integration/Adapters.ts Outdated Show resolved Hide resolved
packages/node-api/integration/LoAuthorityList.ts Outdated Show resolved Hide resolved
packages/node-api/integration/LoAuthorityList.ts Outdated Show resolved Hide resolved
@benoitdevos benoitdevos force-pushed the feature/parachain-node-api branch from 791bc3f to fef5cb0 Compare April 5, 2024 08:30
@benoitdevos benoitdevos merged commit b1d346a into main Apr 5, 2024
1 check passed
@benoitdevos benoitdevos deleted the feature/parachain-node-api branch April 5, 2024 09:20
This was referenced Apr 5, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdethier gdethier gdethier approved these changes

Assignees

@gdethier gdethier

@benoitdevos benoitdevos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benoitdevos @gdethier