Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove usage of BlockchainSubmissionParams. #260

Merged
merged 2 commits into from
May 13, 2024
Merged

Remove usage of BlockchainSubmissionParams. #260

merged 2 commits into from
May 13, 2024

Conversation

benoitdevos
Copy link
Contributor

  • BlockchainSubmissionParams is not exported any more, though it is till used locally.
  • For the few cases where there is no payload, BasicBlockchainSubmission is used.
  • For the rare cases (currently only accept, where the actual blockchain submission depends on whether the requester has a Polkadot account or not) where there signer/callback is optional, OptionalBlockchainSubmission is used.

logion-network/logion-internal#1246

@benoitdevos benoitdevos requested a review from gdethier May 13, 2024 12:19
@benoitdevos benoitdevos mentioned this pull request May 13, 2024
Merged
gdethier
gdethier approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@gdethier gdethier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! I have one little suggestion.

packages/client/src/Signer.ts Outdated Show resolved Hide resolved
@benoitdevos benoitdevos merged commit c09d0ec into main May 13, 2024
1 check passed
@benoitdevos benoitdevos deleted the feature/remove-blockchain-sub-params branch May 13, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdethier gdethier gdethier approved these changes

Assignees

@gdethier gdethier

@benoitdevos benoitdevos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benoitdevos @gdethier