Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tokens records search. #546

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Tokens records search. #546

merged 1 commit into from
Mar 12, 2024

Conversation

benoitdevos
Copy link
Contributor

  • Add a new button to check if a Tokens record with id is present in the collection.
  • If the input value is not a hash, it will be considered as a business key, and hashed before search.
  • A maximum size of 1000 is set to prevent crashing the front in case of huge tokens records set - to be adapted when real backend paging is available.
  • Some minor fixes.

logion-network/logion-internal#1158

Copy link
Contributor

@gdethier gdethier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! I have a small question and a general remark: the limit of 1000 elements should be tested. Indeed, we will very soon have a project with a little more than 15000 records. If is still works, even slowly, with that number of records, we do not need to implement backend-side paging. If it does not, then we have to address this urgently.

src/loc/record/TokensRecordFrame.tsx Show resolved Hide resolved
@benoitdevos
Copy link
Contributor Author

benoitdevos commented Mar 12, 2024

Good job! I have a small question and a general remark: the limit of 1000 elements should be tested. Indeed, we will very soon have a project with a little more than 15000 records. If is still works, even slowly, with that number of records, we do not need to implement backend-side paging. If it does not, then we have to address this urgently.

As discussed, it might not be necessary. If yes, a proper bacend-side paging should then be planned in an upcoming sprint.

@benoitdevos benoitdevos merged commit 84db381 into main Mar 12, 2024
2 checks passed
@benoitdevos benoitdevos deleted the feature/tokens-records-search branch March 12, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants