Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable address copy from selector #554

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Enable address copy from selector #554

merged 1 commit into from
Mar 26, 2024

Conversation

gdethier
Copy link
Contributor

@gdethier gdethier commented Mar 26, 2024 •
edited
Loading

  • Follows Improve wallet and vault screens #553
  • Same behavior as Polkadot.js (hover on address icon shows "copy" cursor and click actually copies to clipboard).
  • Added a very simple notification framework (one notification at a time).

logion-network/logion-internal#1188

@gdethier gdethier requested a review from benoitdevos March 26, 2024 10:01
benoitdevos
benoitdevos approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@benoitdevos benoitdevos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice !

@gdethier gdethier merged commit 9f1aff6 into main Mar 26, 2024
2 checks passed
@gdethier gdethier deleted the feature/selector-copy-address branch March 26, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benoitdevos benoitdevos benoitdevos approved these changes

Assignees

@gdethier gdethier

@benoitdevos benoitdevos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gdethier @benoitdevos