Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request Transaction LOC in same way as Collection #558

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Request Transaction LOC in same way as Collection #558

merged 1 commit into from
Mar 28, 2024

Conversation

benoitdevos
Copy link
Contributor

  • Request Transaction LOC in same way as Collection. (previously, it was with a Dialog)
  • Remove some useless specific components and factor them out into more generic ones.

Open issue
DataLocRequest is used to request either a Transaction or Collection LOC. It's the equivalent of IdentityLocRequest. The wording DataLoc might not adequately reflect this usage. A better name could be found.

logion-network/logion-internal#1196

@benoitdevos benoitdevos requested a review from gdethier March 28, 2024 16:52
gdethier
gdethier approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@gdethier gdethier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@benoitdevos benoitdevos merged commit 25329d3 into main Mar 28, 2024
2 checks passed
@benoitdevos benoitdevos deleted the feature/transaction-request-screen branch March 28, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdethier gdethier gdethier approved these changes

Assignees

@gdethier gdethier

@benoitdevos benoitdevos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benoitdevos @gdethier