Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly clear submission state after open and void #565

Merged
merged 1 commit into from
May 8, 2024
Merged

Properly clear submission state after open and void #565

merged 1 commit into from
May 8, 2024

Conversation

gdethier
Copy link
Contributor

@gdethier gdethier commented May 8, 2024

  • Do not destroy component (open and void buttons) so that user can click on button triggering the submission state clearing.
  • Systematically catch all errors thrown by await submitCall(call).

logion-network/logion-internal#1134
logion-network/logion-internal#1194

@gdethier gdethier requested a review from benoitdevos May 8, 2024 08:23
benoitdevos
benoitdevos approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@benoitdevos benoitdevos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job !

@gdethier gdethier merged commit 42a3a9d into main May 8, 2024
2 checks passed
@gdethier gdethier deleted the feature/fix-open-void branch May 8, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benoitdevos benoitdevos benoitdevos approved these changes

Assignees

@gdethier gdethier

@benoitdevos benoitdevos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gdethier @benoitdevos