Added directSignIn parameter to client signIn method
#62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… allow invoking the sign-in process directly
simeng-li
approved these changes
Jul 16, 2024
|
@jonsamwell cloud you add signatures and re-submit the commit? We require all the commits to be signed in the Logto code base. Also, there was a new version bumped PR just merged to the master, you might need to update your version to 2.0.3 and resolve the conflicts. Thanks. |
Merged
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added directSignIn parameter to client
signInmethod. This parameter allows you to skip the first screen and invoke the sign-in process directly. ** Introduces a breaking change by adding optional named method parameters **Testing
Unit and manual testing
Checklist
.changelog