This repository has been archived by the owner on Apr 11, 2024. It is now read-only.
Add procedure calling convention #26
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs/LoongArch-ELF-ABI-EN.adoc
xry111
reviewed
Nov 7, 2021
| .. A place to store the values of saved registers. | ||
| .. A place for local data storage. | ||
|
|
||
| . The stack grows downwards (towards lower addresses) and the stack pointer shall be aligned to a 128-bit boundary upon procedure entry. The first argument passed on the stack is located at offset zero of the stack pointer on function entry; following arguments are stored at correspondingly higher addresses. |
There was a problem hiding this comment.
目前的 gcc 代码中 ILP32 使用 64 位栈对齐，LP64 使用 128 位栈对齐：https://github.com/loongson/gcc/blob/loongarch-12/gcc/config/loongarch/loongarch.h#L703
要改为都使用 128 位对齐吗？
There was a problem hiding this comment.
目前这块只包含lp64d的情况，而且也明确了在lp64d的情况下，这边写的。32位的还没成熟，暂不考虑包含在文档中。
yetist
reviewed
Nov 9, 2021
| @@ -316,7 +317,7 @@ v1.00 定义的指令集架构 | |||
|
|
|||
| |`ilp32s` / `default` | |||
| |GNU/Linux | |||
| |`loongarch32-linux-gnusfp` | |||
| |`loongarch32-linux-gnusf` | |||
There was a problem hiding this comment.
gnu后面加字符，这个感觉有点怪怪的，而且存在对现有工具的兼容性问题吧？比如一些类似*-linux-gnu这种匹配代码。
There was a problem hiding this comment.
gnu后面加字符，这个感觉有点怪怪的，而且存在对现有工具的兼容性问题吧？比如一些类似*-linux-gnu这种匹配代码。
我感觉加在loongarch32更合适，loongarch32sf-linux-gnu loongarch32f32-linux-gnu loongarch32f64-linux-gnu
There was a problem hiding this comment.
|
#25 已经合并了，请把重复的补丁去掉，重新提交一下。 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add procedure calling convention.