refactor: move non-core booters to their own packages

CODEOWNERS

@@ -246,6 +246,7 @@
 # - Primary owner(s): @jannyHou
 # - Standby owner(s): n/a
 /packages/boot @jannyHou
+/packages/booter @raymondfeng @jannyHou
 
 #
 # Migration from LB3

docs/site/MONOREPO.md

@@ -56,6 +56,7 @@ one in the monorepo: `npm run update-monorepo-file`
 | [packages/authentication](https://github.com/strongloop/loopback-next/tree/master/packages/authentication)                           | @loopback/authentication                   | A LoopBack component for authentication support.                                                                                                                                                                                                                                                |
 | [packages/authorization](https://github.com/strongloop/loopback-next/tree/master/packages/authorization)                             | @loopback/authorization                    | A LoopBack component for authorization support.                                                                                                                                                                                                                                                 |
 | [packages/boot](https://github.com/strongloop/loopback-next/tree/master/packages/boot)                                               | @loopback/boot                             | A collection of Booters for LoopBack 4 Applications                                                                                                                                                                                                                                             |
+| [packages/booter](https://github.com/strongloop/loopback-next/tree/master/packages/booter)                                           | @loopback/booter                           | @loopback/booter                                                                                                                                                                                                                                                                                |
 | [packages/booter-lb3app](https://github.com/strongloop/loopback-next/tree/master/packages/booter-lb3app)                             | @loopback/booter-lb3app                    | A booter component for LoopBack 3 applications to expose their REST API via LoopBack 4                                                                                                                                                                                                          |
 | [packages/build](https://github.com/strongloop/loopback-next/tree/master/packages/build)                                             | @loopback/build                            | A set of common scripts and default configurations to build LoopBack 4 or other TypeScript modules                                                                                                                                                                                              |
 | [packages/cli](https://github.com/strongloop/loopback-next/tree/master/packages/cli)                                                 | @loopback/cli                              | Yeoman generator for LoopBack 4                                                                                                                                                                                                                                                                 |

extensions/graphql/package.json

@@ -29,10 +29,11 @@
     "type-graphql": "^1.1.0"
   },
   "peerDependencies": {
-    "@loopback/boot": "^3.0.2",
+    "@loopback/booter": "^1.0.0",
     "@loopback/core": "^2.11.0"
   },
   "devDependencies": {
+    "@loopback/booter": "^1.0.0",
     "@loopback/boot": "^3.0.2",
     "@loopback/build": "^6.2.5",
     "@loopback/core": "^2.11.0",

extensions/graphql/src/booters/resolver.booter.ts

@@ -6,9 +6,9 @@
 import {
   ArtifactOptions,
   BaseArtifactBooter,
-  BootBindings,
   booter,
-} from '@loopback/boot';
+  BooterBindings,
+} from '@loopback/booter';
 import {
   Application,
   config,
@@ -41,7 +41,7 @@ export class GraphQLResolverBooter extends BaseArtifactBooter {
   constructor(
     @inject(CoreBindings.APPLICATION_INSTANCE)
     public app: Application,
-    @inject(BootBindings.PROJECT_ROOT) projectRoot: string,
+    @inject(BooterBindings.PROJECT_ROOT) projectRoot: string,
     @config()
     public interceptorConfig: ArtifactOptions = {},
   ) {

extensions/graphql/tsconfig.json

@@ -13,6 +13,9 @@
     {
       "path": "../../packages/boot/tsconfig.json"
     },
+    {
+      "path": "../../packages/booter/tsconfig.json"
+    },
     {
       "path": "../../packages/core/tsconfig.json"
     },

extensions/typeorm/package.json

@@ -22,7 +22,7 @@
     "access": "public"
   },
   "peerDependencies": {
-    "@loopback/boot": "^3.0.2",
+    "@loopback/booter": "^1.0.0",
     "@loopback/core": "^2.11.0",
     "@loopback/rest": "^8.0.0"
   },
@@ -31,6 +31,7 @@
     "typeorm": "^0.2.28"
   },
   "devDependencies": {
+    "@loopback/booter": "^1.0.0",
     "@loopback/boot": "^3.0.2",
     "@loopback/build": "^6.2.5",
     "@loopback/core": "^2.11.0",

extensions/typeorm/src/typeorm-connection.booter.ts

@@ -6,9 +6,9 @@
 import {
   ArtifactOptions,
   BaseArtifactBooter,
-  BootBindings,
   booter,
-} from '@loopback/boot';
+  BooterBindings,
+} from '@loopback/booter';
 import {config, CoreBindings, inject} from '@loopback/core';
 import debugFactory from 'debug';
 import {ApplicationUsingTypeOrm, ConnectionOptions} from './';
@@ -28,7 +28,7 @@ export class TypeOrmConnectionBooter extends BaseArtifactBooter {
   constructor(
     @inject(CoreBindings.APPLICATION_INSTANCE)
     public app: ApplicationUsingTypeOrm,
-    @inject(BootBindings.PROJECT_ROOT) projectRoot: string,
+    @inject(BooterBindings.PROJECT_ROOT) projectRoot: string,
     @config()
     public entityConfig: ArtifactOptions = {},
   ) {

extensions/typeorm/tsconfig.json

@@ -13,6 +13,9 @@
     {
       "path": "../../packages/boot/tsconfig.json"
     },
+    {
+      "path": "../../packages/booter/tsconfig.json"
+    },
     {
       "path": "../../packages/core/tsconfig.json"
     },

packages/boot/package.json

@@ -27,11 +27,7 @@
     "@loopback/core": "^2.11.0"
   },
   "dependencies": {
-    "@loopback/model-api-builder": "^2.1.16",
-    "@loopback/repository": "^3.1.0",
-    "@loopback/service-proxy": "^3.0.2",
-    "@types/debug": "^4.1.5",
-    "@types/glob": "^7.1.3",
+    "@loopback/booter": "^1.0.0",
     "debug": "^4.2.0",
     "glob": "^7.1.6",
     "tslib": "^2.0.3"
@@ -40,9 +36,9 @@
     "@loopback/build": "^6.2.5",
     "@loopback/core": "^2.11.0",
     "@loopback/eslint-config": "^10.0.1",
-    "@loopback/rest": "^8.0.0",
-    "@loopback/rest-crud": "^0.8.16",
     "@loopback/testlab": "^3.2.7",
+    "@types/debug": "^4.1.5",
+    "@types/glob": "^7.1.3",
     "@types/node": "^10.17.35"
   },
   "files": [

packages/boot/src/__tests__/acceptance/controller.booter.acceptance.ts

@@ -3,11 +3,7 @@
 // This file is licensed under the MIT License.
 // License text available at https://opensource.org/licenses/MIT
 
-import {
-  createRestAppClient,
-  givenHttpServerConfig,
-  TestSandbox,
-} from '@loopback/testlab';
+import {expect, givenHttpServerConfig, TestSandbox} from '@loopback/testlab';
 import {resolve} from 'path';
 import {BooterApp} from '../fixtures/application';
 
@@ -18,17 +14,10 @@ describe('controller booter acceptance tests', () => {
   beforeEach('reset sandbox', () => sandbox.reset());
   beforeEach(getApp);
 
-  afterEach(stopApp);
-
-  it('binds controllers using ControllerDefaults and REST endpoints work', async () => {
+  it('binds controllers using ControllerDefaults', async () => {
     await app.boot();
-    await app.start();
-
-    const client = createRestAppClient(app);
-
-    // Default Controllers = /controllers with .controller.js ending (nested = true);
-    await client.get('/one').expect(200, 'ControllerOne.one()');
-    await client.get('/two').expect(200, 'ControllerTwo.two()');
+    const bindings = app.find('controllers.*');
+    expect(bindings.length).to.eql(2);
   });
 
   async function getApp() {
@@ -44,8 +33,4 @@ describe('controller booter acceptance tests', () => {
       rest: givenHttpServerConfig(),
     });
   }
-
-  async function stopApp() {
-    await app?.stop();
-  }
 });

packages/boot/src/__tests__/fixtures/application.ts

@@ -3,19 +3,10 @@
 // This file is licensed under the MIT License.
 // License text available at https://opensource.org/licenses/MIT
 
-import {ApplicationConfig} from '@loopback/core';
-import {RepositoryMixin} from '@loopback/repository';
-import {RestApplication} from '@loopback/rest';
-import {ServiceMixin} from '@loopback/service-proxy';
+import {Application, ApplicationConfig} from '@loopback/core';
 import {BootMixin} from '../..';
 
-// Force package.json to be copied to `dist` by `tsc`
-// eslint-disable-next-line @typescript-eslint/no-unused-vars
-import * as pkg from './package.json';
-
-export class BooterApp extends BootMixin(
-  ServiceMixin(RepositoryMixin(RestApplication)),
-) {
+export class BooterApp extends BootMixin(Application) {
   constructor(options?: ApplicationConfig) {
     super(options);
     this.projectRoot = __dirname;

packages/boot/src/__tests__/fixtures/bindable-classes.artifact.ts

@@ -1,4 +1,4 @@
-// Copyright IBM Corp. 2019. All Rights Reserved.
+// Copyright IBM Corp. 2019,2020. All Rights Reserved.
 // Node module: @loopback/boot
 // This file is licensed under the MIT License.
 // License text available at https://opensource.org/licenses/MIT

packages/boot/src/__tests__/fixtures/interceptor.artifact.ts

@@ -1,4 +1,4 @@
-// Copyright IBM Corp. 2019. All Rights Reserved.
+// Copyright IBM Corp. 2019,2020. All Rights Reserved.
 // Node module: @loopback/boot
 // This file is licensed under the MIT License.
 // License text available at https://opensource.org/licenses/MIT

packages/boot/src/__tests__/fixtures/lifecycle-observer.artifact.ts

@@ -1,4 +1,4 @@
-// Copyright IBM Corp. 2018. All Rights Reserved.
+// Copyright IBM Corp. 2018,2020. All Rights Reserved.
 // Node module: @loopback/boot
 // This file is licensed under the MIT License.
 // License text available at https://opensource.org/licenses/MIT

packages/boot/src/__tests__/fixtures/multiple.artifact.ts

@@ -3,17 +3,13 @@
 // This file is licensed under the MIT License.
 // License text available at https://opensource.org/licenses/MIT
 
-import {get} from '@loopback/rest';
-
 export class ArtifactOne {
-  @get('/one')
   one() {
     return 'ControllerOne.one()';
   }
 }
 
 export class ArtifactTwo {
-  @get('/two')
   two() {
     return 'ControllerTwo.two()';
   }

packages/boot/src/__tests__/fixtures/non-global-interceptor.artifact.ts

@@ -1,4 +1,4 @@
-// Copyright IBM Corp. 2019. All Rights Reserved.
+// Copyright IBM Corp. 2019,2020. All Rights Reserved.
 // Node module: @loopback/boot
 // This file is licensed under the MIT License.
 // License text available at https://opensource.org/licenses/MIT

packages/boot/src/__tests__/fixtures/service-class.artifact.ts

@@ -1,4 +1,4 @@
-// Copyright IBM Corp. 2019. All Rights Reserved.
+// Copyright IBM Corp. 2019,2020. All Rights Reserved.
 // Node module: @loopback/boot
 // This file is licensed under the MIT License.
 // License text available at https://opensource.org/licenses/MIT

packages/boot/src/__tests__/fixtures/service-provider.artifact.ts

@@ -1,4 +1,4 @@
-// Copyright IBM Corp. 2019. All Rights Reserved.
+// Copyright IBM Corp. 2019,2020. All Rights Reserved.
 // Node module: @loopback/boot
 // This file is licensed under the MIT License.
 // License text available at https://opensource.org/licenses/MIT

packages/boot/src/__tests__/unit/boot.component.unit.ts

@@ -10,8 +10,6 @@ import {
   BootMixin,
   Bootstrapper,
   ControllerBooter,
-  DataSourceBooter,
-  RepositoryBooter,
   ServiceBooter,
 } from '../../';
 
@@ -34,20 +32,6 @@ describe('boot.component unit tests', () => {
     expect(booterInst).to.be.an.instanceOf(ControllerBooter);
   });
 
-  it('RepositoryBooter is bound as a booter by default', async () => {
-    const booterInst = await app.get(
-      `${BootBindings.BOOTERS}.RepositoryBooter`,
-    );
-    expect(booterInst).to.be.an.instanceOf(RepositoryBooter);
-  });
-
-  it('DataSourceBooter is bound as a booter by default', async () => {
-    const booterInst = await app.get(
-      `${BootBindings.BOOTERS}.DataSourceBooter`,
-    );
-    expect(booterInst).to.be.an.instanceOf(DataSourceBooter);
-  });
-
   it('ServiceBooter is bound as a booter by default', async () => {
     const booterInst = await app.get(`${BootBindings.BOOTERS}.ServiceBooter`);
     expect(booterInst).to.be.an.instanceOf(ServiceBooter);

packages/boot/src/__tests__/unit/boot.custom-binding.component.unit.ts

@@ -1,8 +1,9 @@
-// Copyright IBM Corp. 2019. All Rights Reserved.
+// Copyright IBM Corp. 2020. All Rights Reserved.
 // Node module: @loopback/boot
 // This file is licensed under the MIT License.
 // License text available at https://opensource.org/licenses/MIT
 
+import {BaseArtifactBooter} from '@loopback/booter';
 import {
   Application,
   BindingKey,
@@ -13,7 +14,6 @@ import {
 } from '@loopback/core';
 import {expect} from '@loopback/testlab';
 import {BootBindings, BootMixin} from '../../';
-import {BaseArtifactBooter} from '../../booters';
 import {InstanceWithBooters} from '../../types';
 
 describe('boot.component unit tests', () => {

packages/boot/src/__tests__/unit/booters/service.booter.unit.ts

@@ -4,7 +4,6 @@
 // License text available at https://opensource.org/licenses/MIT
 
 import {Application} from '@loopback/core';
-import {ApplicationWithServices, ServiceMixin} from '@loopback/service-proxy';
 import {expect, sinon, TestSandbox} from '@loopback/testlab';
 import {resolve} from 'path';
 import {ServiceBooter, ServiceDefaults} from '../../..';
@@ -15,7 +14,7 @@ describe('service booter unit tests', () => {
   const SERVICES_PREFIX = 'services';
   const SERVICES_TAG = 'service';
 
-  class AppWithRepo extends ServiceMixin(Application) {}
+  class AppWithRepo extends Application {}
 
   let app: AppWithRepo;
   // eslint-disable-next-line @typescript-eslint/no-explicit-any
@@ -32,10 +31,7 @@ describe('service booter unit tests', () => {
       resolve(__dirname, '../../fixtures/service-provider.artifact.js'),
     );
 
-    const booterInst = new ServiceBooter(
-      normalApp as ApplicationWithServices,
-      sandbox.path,
-    );
+    const booterInst = new ServiceBooter(normalApp, sandbox.path);
 
     booterInst.discovered = [
       resolve(sandbox.path, 'service-provider.artifact.js'),

packages/boot/src/__tests__/unit/bootstrapper.unit.ts

@@ -1,17 +1,14 @@
-// Copyright IBM Corp. 2019. All Rights Reserved.
+// Copyright IBM Corp. 2019,2020. All Rights Reserved.
 // Node module: @loopback/boot
 // This file is licensed under the MIT License.
 // License text available at https://opensource.org/licenses/MIT
 
 import {Application} from '@loopback/core';
-import {RepositoryMixin} from '@loopback/repository';
 import {expect, sinon} from '@loopback/testlab';
 import {BootBindings, Booter, BootMixin, Bootstrapper} from '../..';
 
 describe('boot-strapper unit tests', () => {
-  // RepositoryMixin is added to avoid warning message printed logged to console
-  // due to the fact that RepositoryBooter is a default Booter loaded via BootMixin.
-  class BootApp extends BootMixin(RepositoryMixin(Application)) {}
+  class BootApp extends BootMixin(Application) {}
 
   let app: BootApp;
   let bootstrapper: Bootstrapper;

packages/boot/src/__tests__/unit/mixins/boot.mixin.unit.ts

@@ -1,4 +1,4 @@
-// Copyright IBM Corp. 2019. All Rights Reserved.
+// Copyright IBM Corp. 2019,2020. All Rights Reserved.
 // Node module: @loopback/boot
 // This file is licensed under the MIT License.
 // License text available at https://opensource.org/licenses/MIT