feat: refactor filters into standalone package #6182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achrinza
requested review from
agnes512,
bajtos,
hacksparrow and
raymondfeng
as code owners
achrinza
added
community-contribution
Repository
achrinza
force-pushed
the
feat/filter-standalone
branch
from
6344a88 to
091407e
Compare
achrinza
force-pushed
the
feat/filter-standalone
branch
2 times, most recently
from
ef470fd to
7bbebea
Compare
|
The coverage drop doesn't seem to be related to this PR. |
raymondfeng
reviewed
Aug 24, 2020
raymondfeng
reviewed
Aug 24, 2020
raymondfeng
reviewed
Aug 24, 2020
raymondfeng
reviewed
Aug 24, 2020
|
Thanks for the feedback, I agree with the points and applied them; PTAL. |
raymondfeng
reviewed
Aug 26, 2020
| @@ -0,0 +1,135 @@ | |||
| # @loopback/filter | |||
There was a problem hiding this comment.
Which name is better?
@loopback/filter@loopback/query-filter@loopback/repository-filter
There was a problem hiding this comment.
I prefer @loopback/filter as the filter is use both when working with queries and repositories. Prefixing it with query- or repository- may create confusion that the filter only applies when working with either one of those concepts.
There was a problem hiding this comment.
Good discussion!
I vote for @loopback/filter.
|
@achrinza Good initiative. The change LGTM. Let's settle on the name - https://github.com/strongloop/loopback-next/pull/6182/files#r477425945. |
raymondfeng
approved these changes
Aug 27, 2020
achrinza
force-pushed
the
feat/filter-standalone
branch
from
3979d5a to
794d8b8
Compare
see: loopbackio#5957 Signed-off-by: Rifa Achrinza <[email protected]>
achrinza
force-pushed
the
feat/filter-standalone
branch
from
794d8b8 to
dd012b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see: #5957
Signed-off-by: Rifa Achrinza [email protected]
Checklist
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated👉 Check out how to submit a PR 👈