Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put framework modules to peerDependencies in new extensions #6243

Merged
merged 2 commits into from
Sep 1, 2020

Conversation

bajtos
Copy link
Member

@bajtos bajtos commented Sep 1, 2020

As discussed several times in the past (most recently in #5927 (comment)), extensions should use framework modules from the target application via peerDependencies.

This PR is a spin-off from #5959 which is becoming too difficult to get landed because of merge conflicts. It brings two commits from the original PR:

  • Document the best practice in "Creating components"
  • Update CLI template

Please read #5959 for the original discussion around this proposal. We have reached consensus to follow this new direction, so I hope we can get this PR landed quickly.

Checklist

  • DCO (Developer Certificate of Origin) signed in all commits
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

@bajtos bajtos merged commit 3ee9a39 into master Sep 1, 2020
@bajtos bajtos deleted the feat/extension-peer-deps branch September 1, 2020 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants