Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jamesmoore/arch 166 integrate s3 sync silo into drafter #44

Merged

Conversation

jimmyaxod
Copy link
Contributor

This adds the final pieces required for automatic S3 sync

  • New config 'autostart' which if set will start S3 sync automatically. For a migration destination this should be false.
  • When the storage provider returned by NewDevice is Closed(), it now stops the S3 sync and waits until completed.
  • In FromProtocol, when the eventCompleted is received, it will now call the sync.Start, which grabs from S3 and starts sync.

Implementation notes:

  • This should now be a pure config integration, with just S3 sync config required for each device.
  • To be sure all data is present, the caller should wait for the EventCompleted event and make sure it has been received, since this can now be delayed by local grabbing of S3 data.

@jimmyaxod jimmyaxod force-pushed the jamesmoore/arch-166-integrate-s3-sync-silo-into-drafter branch from 69fec30 to 77b86cc Compare October 31, 2024 22:16
Copy link
Member

@pojntfx pojntfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I quite like the alternative sources configuration, it seems very straight-forward to integrate into Drafter!

@jimmyaxod jimmyaxod merged commit 0c8a323 into main Nov 4, 2024
4 checks passed
@jimmyaxod jimmyaxod deleted the jamesmoore/arch-166-integrate-s3-sync-silo-into-drafter branch November 4, 2024 18:34
@github-actions github-actions bot locked and limited conversation to collaborators Nov 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants