James/arch 69 go through error handling and cleanup #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jimmyaxod
commented
Apr 23, 2024
jimmyaxod
commented
- Tidied up context cancel in ProtocolRW. Now when context cancelled, Handle() returns.
- Removed HandleSend() in FromProtocol. The sends are now done inline rather than separately. This removes potential block if the HandleSend had quit, and something tried to send a packet.
- Added a couple of tests for ProtocolRW context cancelling.
…s will then return context.Cancelled
…est for now (ports)
ARCH-69 Go through error handling and cleanup
Silo needs to make sure no goroutines leaked, no deadlocks etc. Go through and ensure that's the case, add some tests, etc |
jimmyaxod
deleted the
james/arch-69-go-through-error-handling-and-cleanup
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.