ISSUE-204 / Fix event publisher in aggregatestore/model #205
Conversation
|
@superchalupa I think this will fix your issue. |
| @@ -75,7 +75,9 @@ func (r *AggregateStore) Save(ctx context.Context, aggregate eh.Aggregate) error | |||
|
|
|||
| // Publish events if supported by the aggregate. | |||
| if publisher, ok := aggregate.(EventPublisher); ok && r.bus != nil { | |||
| for _, e := range publisher.EventsToPublish() { | |||
| events := publisher.EventsToPublish() | |||
| publisher.ClearEvents() | |||
There was a problem hiding this comment.
Will we lost all of events if an error happen?
There was a problem hiding this comment.
This line should move to after the loop
There was a problem hiding this comment.
I choose the same "guarantee" as the ES version, which is to clear all events before publishing, no matter what the result of publishing is. If an error happens here it will trickle to the command handler anyway, and should be handled by the client with a new request. There is a much broader issue about what to do with failing events in #181.
There was a problem hiding this comment.
This looks like it will work. I'll apply and check.
There was a problem hiding this comment.
Everything checks out. The old code crashed without my hack. Everything works ok with upstream master now. Thanks.
Summary
The events that have been published should be cleared in the aggregatestore/model EventPublisher.
How to test
Issue
Fixes #204.
Notes