root: allow updates on the root target ('$') #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, nice, it would be great to extend the merging functionality to support the top-level target! However, I don't see this working as I expected, could you add a test or two, or even just a working command example? I tried to use the overlay in #6 but it's not updating the sample document I'm using. |
paulRbr
force-pushed
the
allow-root-target
branch
from
176f2f5 to
0b900b7
Compare
This commit allows for updates on the root target ('$'). The Jsonpath
lib doesn't know how to treat `.apply(` when the target is the root
object rightly so. Instead, let's manually merge the global spec
object when the JSON path target is '$'.
About lornajane#6
paulRbr
force-pushed
the
allow-root-target
branch
from
0b900b7 to
0d18f96
Compare
|
Thanks for taking a look @lornajane. I've fixed the code and pushed a test case to show it works :) Let me know what you think. |
lornajane
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit allows for updates on the root target ('$'). The Jsonpath
lib doesn't know how to treat
.apply(when the target is the rootobject rightly so. Instead, let's manually merge the global spec
object when the JSON path target is '$'.
About #6