Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow local_archive paths to be labels #33

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Conversation

cfrantz
Copy link
Collaborator

@cfrantz cfrantz commented Dec 6, 2023

  1. If a local_archive path looks like a label, interpret it as such.

Copy link
Collaborator

@pamaury pamaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Should you also consider it a path if it starts with // ?

1. If a local_archive path looks like a label, interpret it as such.

Signed-off-by: Chris Frantz <[email protected]>
@cfrantz cfrantz force-pushed the local-archive-with-label branch from 4de64bf to 63e02b3 Compare December 6, 2023 23:29
@cfrantz
Copy link
Collaborator Author

cfrantz commented Dec 6, 2023

Looks good to me. Should you also consider it a path if it starts with // ?

Yes, good catch. (I assume you mean "consider it a label if it starts with //).

@cfrantz cfrantz merged commit e6f9c95 into main Dec 6, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants