Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rv_core_ibex] Move Ibex verification_stage to V2S #23944

Merged
merged 1 commit into from
Jul 5, 2024
Merged

[rv_core_ibex] Move Ibex verification_stage to V2S #23944

merged 1 commit into from
Jul 5, 2024

Conversation

vogelpi
Copy link
Contributor

@vogelpi vogelpi commented Jul 5, 2024

This resolves #23542.

@vogelpi vogelpi requested review from GregAC and andreaskurth July 5, 2024 21:22
andreaskurth
andreaskurth approved these changes Jul 5, 2024
View reviewed changes
Copy link
Contributor

@andreaskurth andreaskurth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based on the evidence collected in #23542. Thx!

@vogelpi
Copy link
Contributor Author

vogelpi commented Jul 5, 2024

CHANGE AUTHORIZED: hw/ip/rv_core_ibex/data/rv_core_ibex.hjson

1 similar comment
@andreaskurth
Copy link
Contributor

CHANGE AUTHORIZED: hw/ip/rv_core_ibex/data/rv_core_ibex.hjson

@vogelpi
Copy link
Contributor Author

vogelpi commented Jul 5, 2024

Merging as the relevant CI checks have passed.

@vogelpi vogelpi merged commit 9edf84e into lowRISC:master Jul 5, 2024
24 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreaskurth andreaskurth andreaskurth approved these changes

@GregAC GregAC Awaiting requested review from GregAC

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[rv_core_ibex, dv] V2(S) sign-off
2 participants
@vogelpi @andreaskurth