[aes] Fix aes_fvsr_key_batch on CW305 #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the commands for seeding the batch PRNG and seeting the fixed key seemed to interfere resulting in the target implemented on the CW305 getting completely out of sync. Signed-off-by: Pirmin Vogel <[email protected]>
vogelpi
requested review from
abdullahvarici,
alphan,
andreaskurth and
vrozic
as code owners
abdullahvarici
approved these changes
Apr 17, 2023
There was a problem hiding this comment.
LGTM. Thanks Pirmin but we can think this as a temporary and quick fix. But at the end we should implement Colin's suggestion but it also needs some modification on OTBN binary side.
Thanks for your review @abdullahvarici ! Ah, that's were this issue is :-) I vaguely remembered something but forgot to check. I agree that we should investigate this and come up with a real/more reliable fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the commands for seeding the batch PRNG and seeting the fixed key seemed to interfere resulting in the target implemented on the CW305 getting completely out of sync.