[CI] Test TVLA trace-filtering in CI #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vrozic
requested review from
alphan,
andreaskurth and
vogelpi
as code owners
At the moment the default value of the `--general-test` parameter is `True`. This argument cannot be changed to `False` via command line, but only through the yaml configuration file. Since we don't use configuaration files for TVLA in the CI, it is currently impossible to add tests for aes-specific TVLA. To enable adding these tests, this commit changes the default value to `False` and adds `--general-test` to CI commands where needed. Signed-off-by: Vladimir Rozic <[email protected]>
This commit adds a CI test that checks if the TVLA trace filtaring (currently only enabled for aes-byte-specific analysis) works properly. Checked in project traces are artificially polluted in such way that 90% of the traces are unusable. The test checks that at most 100 (out of 1000) traces are used by the TVLA. Signed-off-by: Vladimir Rozic <[email protected]>
vrozic
force-pushed
the
ci-tvla-filtering
branch
from
8f5b1f5 to
9b01d81
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a CI test to check if trace filtering works in
tvla.pyto partially address issue #96.The first commit changes default value of
--general-testargument. This change was necessary to enable running non-general tvla tests without checking-in yaml configuration files.The second commit checks-in a project with artificial traces and adds a CI test. The project contains 1000 traces, out of which 900 were polluted to fail the filtering. The test checks that
tvla.pyused at most 100 traces.