Skip to content

Commit

Permalink
sw: bug fix for the pinmux_check
Browse files Browse the repository at this point in the history
Check only waited for an empty fifo and not for the transmission to be
finished. New pinmux driver allowed optimisations caused the check to
break because of this.

Co-authored-by: Alex Jones <[email protected]>
  • Loading branch information
HU90m and AlexJones0 committed Nov 14, 2024
1 parent 386b24c commit 453f0b2
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions sw/cheri/checks/pinmux_check.cc
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,7 @@ using namespace CHERI;
* Blocks until the UART transmit FIFO is empty.
*/
void block_until_uart_tx_done(Capability<volatile OpenTitanUart> uart) {
while (uart->transmit_fifo_level() > 0) {
asm volatile("");
}
while (!(uart->status & uart->StatusTransmitIdle));
}

/**
Expand Down

0 comments on commit 453f0b2

Please sign in to comment.