Connect SPI for headers #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both in top_sonata and sonata_system there were missing comments for signal groups. This commit also aligns all the signals in a module definition.
GregAC
approved these changes
May 27, 2024
There was a problem hiding this comment.
LGTM though we should add the new SPI blocks to the table in the SPI doc: https://github.com/lowRISC/sonata-system/blob/main/doc/ip/spi.md
Good, point added that now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two SPI instances on the R-Pi hat, one on the Arduino shield and one on the mikroBUS click.
This PR has been built but not tested with physical headers.
The first three commits are code clean up so feel free to skip those and only review the last three commits.