Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rgbled ctrl #111

Merged
merged 3 commits into from
May 28, 2024
Merged

Rgbled ctrl #111

merged 3 commits into from
May 28, 2024

Conversation

GregAC
Copy link
Contributor

@GregAC GregAC commented May 28, 2024

Please excuse the lack of comments and documentation can add these with a follow up PR

@GregAC GregAC requested a review from marnovandermaas May 28, 2024 15:21
Copy link
Contributor

@marnovandermaas marnovandermaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting this error on my local simulator build:

ERROR: %Warning-SYMRSVDWORD: ../src/lowrisc_ip_rgbled_ctrl_0.1/rtl/rgbled_ctrl_reg_pkg.sv:54:7: Symbol ma
tches C++ common word: 'set'
   54 |     } set;
      |       ^~~
                      ... For warning description see https://verilator.org/warn/SYMRSVDWORD?v=5.024
                      ... Use "/* verilator lint_off SYMRSVDWORD */" and lint_on around source to disable
 this message.
%Error: Exiting due to 1 warning(s)
        ... See the manual at https://verilator.org/verilator_doc.html for more assistance.
make: *** [Makefile:16: Vtop_verilator.mk] Error 1

ERROR: Failed to build lowrisc:sonata:system:0 : '['make', '-j', '8']' exited with an error: 2

Copy link
Contributor

@marnovandermaas marnovandermaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this and it works on my board. Also the simulator compiles without warnings.

@marnovandermaas marnovandermaas merged commit 2d5aa1f into lowRISC:main May 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants