Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert device alignment reductions #315

Merged
merged 2 commits into from
Nov 11, 2024
Merged

Revert device alignment reductions #315

merged 2 commits into from
Nov 11, 2024

Conversation

marnovandermaas
Copy link
Contributor

This reverts commit 9054000.

This reversion avoids increasing the pressure of decoding addresses on the crossbar.

@marnovandermaas
Revert "Devices 32 byte aligned not 64 byte"
a586ed1 
This reverts commit 9054000.

This reversion avoids increasing the pressure of decoding addresses on
the crossbar.
GregAC
GregAC approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@GregAC GregAC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me, was this motivated by a particular issue/analysis or just a desire to generally ease timing in this area?

HU90m
HU90m previously requested changes Nov 4, 2024
View reviewed changes
Copy link
Member

@HU90m HU90m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably revert both this and a75d83616fd22d63860ba1bd9cca17f2fb692d69 in one, no?

@HU90m
Copy link
Member

HU90m commented Nov 4, 2024

Looks reasonable to me, was this motivated by a particular issue/analysis or just a desire to generally ease timing in this area?

I did this back when the plan was to move the GPIO addressing into the main crossbar, rather than use the gpio_array module.

@marnovandermaas
Copy link
Contributor Author

We should probably revert both this and a75d83616fd22d63860ba1bd9cca17f2fb692d69 in one, no?

Good point, I had forgotten it was lowered in two steps. This should be in now.

@marnovandermaas marnovandermaas marked this pull request as ready for review November 6, 2024 09:24
@marnovandermaas marnovandermaas changed the title Revert "Devices 32 byte aligned not 64 byte" Revert device alignment reductions Nov 11, 2024
@marnovandermaas marnovandermaas merged commit 2700cbb into lowRISC:main Nov 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GregAC GregAC GregAC approved these changes

@HU90m HU90m Awaiting requested review from HU90m

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marnovandermaas @HU90m @GregAC