Fix SPI controller interrupt routing #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the semantic change to the `SPI_NUM` parameter, the final 3 SPI controllers lost their ability to stimulate the PLIC. Correct the wiring.
Rx and Tx were transposed in the comments.
HU90m
approved these changes
Nov 6, 2024
There was a problem hiding this comment.
@engdoreis I'm concerned that this wasn't caught by the interrupt test. I've created #325
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the semantic change to the
SPI_NUMparameter, the final 3 SPI controllers lost their ability to stimulate the PLIC. Correct the wiring.(Built into FPGA on top of PR #323 and timing-clean; tests/test_runner passing.)